Skip to content

Fix for MODCLUSTER-432 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix for MODCLUSTER-432 #118

wants to merge 2 commits into from

Conversation

jfclere
Copy link
Member

@jfclere jfclere commented Oct 7, 2014

note that the test also works with java 1.7 on macosx for example.

@modcluster-pull-request
Copy link

Triggering build using a merge of 2d8d325 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/

@modcluster-pull-request
Copy link

Build 101 outcome was SUCCESS using a merge of 2d8d325 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/101
Public: https://hudson.jboss.org/hudson/job/mod_cluster-1.3.x-pull-player-executor/101

rhusar
rhusar reviewed Oct 7, 2014
View reviewed changes
core/src/test/java/org/jboss/modcluster/advertise/MulticastSocketFactoryImplTestCase.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, lets be nice, no? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops fixing now.

@modcluster-pull-request
Copy link

Triggering build using a merge of 38552f3 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/

@modcluster-pull-request
Copy link

Build 102 outcome was SUCCESS using a merge of 38552f3 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/102
Public: https://hudson.jboss.org/hudson/job/mod_cluster-1.3.x-pull-player-executor/102

@modcluster-pull-request
Copy link

Triggering build using a merge of 9d5d259 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/

@modcluster-pull-request
Copy link

Build 103 outcome was SUCCESS using a merge of 9d5d259 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/103
Public: https://hudson.jboss.org/hudson/job/mod_cluster-1.3.x-pull-player-executor/103

@jfclere
Copy link
Member Author

jfclere commented Oct 14, 2014

I will propose another patch according to my previous comment.

@jfclere jfclere closed this Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfclere @modcluster-pull-request @rhusar