[1.2] MODCLUSTER-430, Re-creating proxy_module configuration structures in ord...

[Karm]

...er to have them unique, not being shared with the main_server. Furthermore, some minor httpd 2.2.x compatibility fix and additional logging. See pull/119 for details...

[Karm]

An unused variable. It has been deleted from 1.3.x (master) already.

[modcluster-pull-request]

Triggering build using a merge of c40f373 on branch 1.2.x:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/

[modcluster-pull-request]

Build 108 outcome was SUCCESS using a merge of c40f373 on branch 1.2.x:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/108
Public: https://hudson.jboss.org/hudson/job/mod_cluster-1.3.x-pull-player-executor/108

[Karm]

Hmm, hold on. After the full native test suite execution, it looks like this patch interferes with MODCLUSTER-427. I'll take a look...

Never mind, it was a false alarm :-)

[Karm]

Well, at the moment, please, hold on with merging.
According to the full test suite results, there are side effects of this patch on CreateBalancers 1 scenarios, namely when one tries to use a different balancer name such as balancerxxx.

LoadModule slotmem_module modules/mod_slotmem.so
LoadModule manager_module modules/mod_manager.so
LoadModule proxy_cluster_module modules/mod_proxy_cluster.so
LoadModule advertise_module modules/mod_advertise.so

MemManagerFile "/dev/shm/mod_cluster-eapx/jboss-ews-2.1/httpd/cache/mod_cluster"

ProxyPass / balancer://balancerxxx stickysession=JSESSIONID|jsessionid nofailover=on
ProxyPassReverse / balancer://balancerxxx
ProxyPreserveHost on

ServerName 192.168.122.204:2181

<IfModule manager_module>
  Listen 192.168.122.204:8847
  LogLevel debug
  <VirtualHost 192.168.122.204:8847>
    ServerName 192.168.122.204:8847
    <Directory />
      Order deny,allow
      Deny from all
      Allow from all
    </Directory>
    KeepAliveTimeout 60
    MaxKeepAliveRequests 0
    ServerAdvertise on
    AdvertiseFrequency 5
    ManagerBalancerName balancerxxx
    AdvertiseGroup 224.0.5.79:65009
    EnableMCPMReceive

    CreateBalancers 1

    <Location /mcm>
      SetHandler mod_cluster-manager
      Order deny,allow
      Deny from all
      Allow from all
    </Location>
  </VirtualHost>
</IfModule>

It's under investigation :)

[Karm]

The error was in the test suite :)
Some tests leveraging CreateBalancers 1 directive were erroneously relying on balancer available in one of the VirtualHosts while having the only ProxyPass directive in the main_server. With this patch and CreateBalancers 1, having the only ProxyPass in the main_server, only the main_server balancer is created -- which is actually the correct behaviour.

It's fit for merge (ﾉ´ヮ´)ﾉ*:･ﾟ✧

[rhusar]

Needs a rebase.

[rhusar]

Linking PR to previous master PR (now closed as needs to be resubmitted): #119.

[antoineco]

@Karm in the linked original issue you mentioned your tests were successful. What's the current status of this PR?

[jfclere]

Need to be rebased and won't be done in mod_cluster but in mod_proxy_cluster