Skip to content

Fix for MODCLUSTER-680. #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fix for MODCLUSTER-680. #364

merged 1 commit into from
Apr 9, 2019

Conversation

jfclere
Copy link
Member

@jfclere jfclere commented Apr 4, 2019 •
edited by rhusar
Loading

@rhusar rhusar self-assigned this Apr 5, 2019
rhusar
rhusar approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can rename the parameters from secure to sslEnabled – I'll do that.

@rhusar rhusar merged commit 3e03ae6 into modcluster:master Apr 9, 2019
@rhusar
Copy link
Member

rhusar commented Apr 9, 2019

@Karm @jfclere Do you think we need a backport to 1.x?

@jfclere
Copy link
Member Author

jfclere commented Apr 9, 2019

Yes please.

@rhusar
Copy link
Member

rhusar commented Apr 9, 2019

1.4 PR - #369

Do we need this for older branches? I wouldn't think so. Let me know.

@jfclere
Copy link
Member Author

jfclere commented Apr 9, 2019

We don't need the older branches.

@rhusar
Copy link
Member

rhusar commented Apr 9, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhusar rhusar rhusar approved these changes

Assignees

@rhusar rhusar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfclere @rhusar