Skip to content

fixes for MODCLUSTER-690 #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2019
Merged

fixes for MODCLUSTER-690 #379

merged 2 commits into from
May 7, 2019

Conversation

jfclere
Copy link
Member

@jfclere jfclere commented Apr 17, 2019

No description provided.

rhusar
rhusar requested changes Apr 17, 2019
View reviewed changes
Copy link
Member

@rhusar rhusar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit messages need to reference Jiras :-)

Also, please link appropriate master PR or indicate if its not needed.

jfclere added 2 commits April 17, 2019 09:32
@jfclere
Fix for MODCLUSTER-690.
7023fb0 
Make sure the SIZEOFSCORE is bigger than sizeof(proxy_worker_shared).
@jfclere
Fix for MODCLUSTER-690.
3851d8d 
The other place where 1.3.x cores in httpd-trunk.
@jfclere jfclere requested a review from rhusar April 17, 2019 07:35
jfclere
jfclere commented Apr 17, 2019
View reviewed changes
Copy link
Member Author

@jfclere jfclere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream commit modcluster/mod_proxy_cluster@d3cb67c

jfclere
jfclere commented Apr 17, 2019
View reviewed changes
Copy link
Member Author

@jfclere jfclere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has been in upstream for years...

@rhusar rhusar assigned rhusar and Karm and unassigned rhusar Apr 23, 2019
@rhusar
Copy link
Member

rhusar commented Apr 23, 2019

@Karm Please review.

@jfclere jfclere merged commit af0bd76 into modcluster:1.3.x May 7, 2019
@jfclere jfclere deleted the 1.3.x branch May 7, 2019 15:19
@Karm
Copy link
Member

Karm commented May 10, 2019

run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhusar rhusar Awaiting requested review from rhusar

Assignees

@Karm Karm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfclere @rhusar @Karm