Revisit MODCLUSTER-337 & MODCLUSTER-338 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty key is not configured" This reverts commit 2e3f92b.
|
Triggering build using a merge of 2cf2670 on branch master: |
|
Build 25 outcome was SUCCESS using a merge of 2cf2670 on branch master: |
jfclere
added a commit
that referenced
this pull request
Jan 29, 2014
Revisit MODCLUSTER-337 & MODCLUSTER-338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisits these two:
https://issues.jboss.org/browse/MODCLUSTER-337
https://issues.jboss.org/browse/MODCLUSTER-338
The original fix was to not send the message digest if the security key was not configured. However, this breaks backward compatibility a little.
I am now proposing a better solution: the digest that 1.2.x native part always sends is computed from zero byte array, thus if the security key is not configured, the Java side will use that for verification. So now all messages are checked for digest.
Also adds trace logging so its easier to debug.