-
Notifications
You must be signed in to change notification settings - Fork 0
홈페이지 디자인 변경사항 반영 및 입금 관리 페이지 라우팅 추가 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ongheong
wants to merge
9
commits into
develop
Choose a base branch
from
fix/MD-11
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e76a751
chore: 메인 페이지에서 텍스트가 다른 부분 반영
yeoeun-ex b23e253
fix: 최신순/오래된순 토글 버튼 추가 및 Homepage 리팩토링
yeoeun-ex a5fdbe7
feat: 입금 관리 페이지 개발 및 라우터 연결
yeoeun-ex d0295a8
chore: 디자인시스템 컴포넌트 적용 및 사용하지 않는 스타일 컴포넌트 제거
yeoeun-ex 3f1e18f
fix: chip 컴포넌트에 onClick 핸들러 props 추가
yeoeun-ex c6a2826
chore: prettieerc 파일이 작동하지 않아 prettierrc.json으로 대체
yeoeun-ex 50c6797
chore: FSD 구조에 맞게 UI 컴포넌트 파일 이동
yeoeun-ex 7c8e8df
chore: button DOM 에러 해결을 위해 기존 버튼 컴포넌트 제거
yeoeun-ex ee393a1
Merge branch 'develop' of https://github.com/moddo-kr/moddo-frontend …
yeoeun-ex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 파일 안에 홈에서 사용하는 ui 컴포넌트들이 함께 들어가 있는데,
저희 FSD 구조 활용해서 ui 컴포넌트들은 따로 ui 디렉토리나 features 쪽에 만들어서 넣어두고 page에서는 조합하는 형태로 해보기로 했던 걸로 기억하고 있거든요..!
api 코드 추가되면서 코드가 더 복잡해지기 전에 여기서 디렉토리 정리를 먼저 해두면 어떨까 싶습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 넵! FSD 구조에 맞게 이동시키겠습니다!