-
Notifications
You must be signed in to change notification settings - Fork 545
Add copilot-setup-steps.yml for .NET 10.0.100 RC1 SDK preinstallation #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+19
−0
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Setup .NET SDK 10.0.100 RC1 | ||
| steps: | ||
| - name: Download and install .NET 10.0.100 RC1 SDK | ||
| run: | | ||
| # Download the .NET install script | ||
| curl -sSL https://dot.net/v1/dotnet-install.sh -o /tmp/dotnet-install.sh | ||
| chmod +x /tmp/dotnet-install.sh | ||
|
|
||
| # Install .NET SDK 10.0.100-rc.1.25451.107 | ||
| /tmp/dotnet-install.sh --version 10.0.100-rc.1.25451.107 --install-dir $HOME/.dotnet | ||
|
|
||
| # Add to PATH | ||
| echo "$HOME/.dotnet" >> $GITHUB_PATH | ||
|
|
||
| # Cleanup | ||
| rm -f /tmp/dotnet-install.sh | ||
| - name: Verify .NET SDK installation | ||
| run: | | ||
| $HOME/.dotnet/dotnet --version | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably use something like this https://github.com/dotnet/aspire/blob/911e1f62c0caa3fae683218f24ef0cd0be3e1efb/.github/workflows/copilot-setup-steps.yml#L35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe something like this:
https://github.com/actions/setup-dotnet?tab=readme-ov-file#using-the-global-json-file-input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot , can you update using the global-json-file approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot, please see the previous comment about global-json-file and update to use that approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create an issue to undo these instructions once .NET 10 is GA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool. We should also update all the workflows I updated in #871 to use
global-json-filetoo. I wonder if we could use that in addition todotnet-versionfor 9.0.x.If we do this, I don't think we'd need an issue specifically for updating instructions since all we'd need to update is the global.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot, can you update using the global-json-file approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copilot's gotten stuck. Trying a new PR.
#877