Skip to content

Call Regex.IsMatch when Match is not needed #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+9 −3
Merged

Call Regex.IsMatch when Match is not needed #903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/ModelContextProtocol.Core/Server/AIFunctionMcpServerResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,21 @@ private AIFunctionMcpServerResource(AIFunction function, ResourceTemplate resour
public override bool IsMatch(string uri)
{
Throw.IfNull(uri);
return TryMatch(uri, out _);

// For templates, use the Regex to parse. For static resources, we can just compare the URIs.
if (_uriParser is null)
{
// This resource is not templated.
return UriTemplate.UriTemplateComparer.Instance.Equals(uri, ProtocolResourceTemplate.UriTemplate);
}

return _uriParser.IsMatch(uri);
}

private bool TryMatch(string uri, out Match? match)
{
// For templates, use the Regex to parse. For static resources, we can just compare the URIs.
if (_uriParser is null)
{
// This resource is not templated.
match = null;
return UriTemplate.UriTemplateComparer.Instance.Equals(uri, ProtocolResourceTemplate.UriTemplate);
}
Expand Down
Loading