Make JsonRpcMessageWithId.RequestId non-required
#984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #892, the
RequestIdproperty inJsonRpcMessageWithIdwas changed to berequiredto align with with the MCP schema. The intention behind this change was to disallow uninitialized values. However:default, which is what happens in practice because...RequestIdto be uninitialized in some cases so that an ID can be dynamically/lazily generatedForcing developers to explicitly set
RequestIdtodefaultdoesn't seem helpful.Changes
This PR reverts
RequestIdto be non-requiredand adjusts internal usage to account for this.Fixes #892 (comment)