Revert "Revert "Update to MTP""

[Youssef1313]

Reverts #989

@baronfel @rainersigwald I assume it's already a bad practice to read Configuration when in props, because the behavior will be different when building a single project (Configuration is set late) vs when building a solution (MSBuild forces Configuration as a global property)

[Youssef1313]

@eiriktsarpalis @stephentoub Can you please double check with this change if all is good now?

[Youssef1313]

This works locally for me. Note: just in case you got build errors related to xunit entry point, make sure to git clean -xdf. The MSBuild target that generates entrypoint on xunit side was missing some input so it can be incorrectly considered up to date after a version update.

[rainersigwald]

@baronfel @rainersigwald I assume it's already a bad practice to read Configuration when in props, because the behavior will be different when building a single project (Configuration is set late) vs when building a solution (MSBuild forces Configuration as a global property)

Exactly correct.

[Youssef1313]

@eiriktsarpalis @stephentoub Can you restart the failing jobs please? Looks like test flakiness.

[Youssef1313]

@eiriktsarpalis @stephentoub This is green now. Can we get it merged again please? Thanks!