-
Notifications
You must be signed in to change notification settings - Fork 274
jsonrpc: expose encoding and decoding functions #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jba
requested changes
Jul 10, 2025
Contributor
|
#117 moves the other JSONRPC symbols to their own package. When that lands, it would be great if you would rebase this onto it and make the corresponding changes. |
Contributor
|
#117 has landed. |
Expose `jsonrpc2.MakeID`, `jsonrpc2.EncodeMessage` and `jsonrpc2.DecodeMessage` functions to allow implementing custom `mcp.Transport`. Add an example that demonstrates a custom transport implementation. Fixes modelcontextprotocol#110
3a89580 to
197c21f
Compare
jba
requested changes
Jul 11, 2025
Contributor
jba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Very close!
Add documentation to exported `jsonrpc` functions.
jba
approved these changes
Jul 14, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
jsonrpc2.MakeID,jsonrpc2.EncodeMessageandjsonrpc2.DecodeMessagefunctions to allow implementing custommcp.Transport. Add an example that demonstrates a custom transport implementation.Fixes #110