Skip to content

mcp/server: fix nil PingParams in server.Ping #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

mcp/server: fix nil PingParams in server.Ping #163

merged 1 commit into from
Jul 23, 2025

Conversation

@samthanawalla
Copy link
Contributor

@samthanawalla samthanawalla commented Jul 23, 2025 •
edited
Loading

Use OrZero in case PingParams is nil to avoid typed nil.

Fixes: #162

@samthanawalla samthanawalla requested a review from jba July 23, 2025 19:40
@samthanawalla samthanawalla marked this pull request as ready for review July 23, 2025 19:40
jba
jba approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@jba jba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for grabbing this.

@jba jba merged commit 94b88a2 into modelcontextprotocol:main Jul 23, 2025
3 checks passed
@samthanawalla samthanawalla deleted the bugFixes branch September 11, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jba jba jba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KeepAlive Ping message send null as params

2 participants

@samthanawalla @jba