mcp/streamable: remove StreamableReconnectOptions #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves MaxRetries into the parent struct and assume a negative integer signifies to not retry. Fixes modelcontextprotocol#308
jba
requested changes
Aug 18, 2025
| func NewStreamableClientTransport(url string, opts *StreamableClientTransportOptions) *StreamableClientTransport { | ||
| t := &StreamableClientTransport{Endpoint: url} | ||
| if opts != nil { | ||
| t.HTTPClient = opts.HTTPClient |
Contributor
There was a problem hiding this comment.
I think we should do our usual trick of storing the opts in the struct, making a shallow copy.
E.g. https://github.com/modelcontextprotocol/go-sdk/blob/main/mcp/client.go#L48.
Contributor
Author
There was a problem hiding this comment.
It looks like we are deprecating StreamableClientTransportOptions in favor of using the StreamableClientTransport literal
Contributor
Author
There was a problem hiding this comment.
Additionally NewStreamableClientTransport will be deleted soon
jba
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves MaxRetries into the parent struct and assume a negative integer signifies to not retry.
Fixes #308