mcp: fix bugs handling pointer types #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bad merging in modelcontextprotocol#338 led to a bad bug in the handling of structured output for pointer output types. Add a conformance test and fix the bug.
findleyr
requested review from
jba and
samthanawalla
and removed request for
jba
samthanawalla
approved these changes
Aug 21, 2025
yasomaru
pushed a commit
to yasomaru/go-sdk
that referenced
this pull request
Aug 28, 2025
Some bad merging in modelcontextprotocol#338 led to a bad bug in the handling of structured output for pointer output types. Add a conformance test and fix the bug.
RatStar811
approved these changes
Nov 19, 2025
RatStar811
approved these changes
Nov 19, 2025
RatStar811
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bad merging in #338 led to a bad bug in the handling of structured output for pointer output types. Add a conformance test and fix the bug.