fix: optimize the postInitializationHook in McpAsyncClient #624
+11
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I believe there might be two issues with the implementation of Function<Initialization, Mono> postInitializationHook in the constructor of the McpAsyncClient class.
Optimization Details
The following optimizations have been made regarding the above two issues;
if (enableCallToolSchemaCaching && listToolsResult.tools() != null)
!Utils.isEmpty(tool.outputSchema())
instead of tool.outputSchema() !=null
to filter.Comparison
Before
After: