WebMvcSseServerTransportProvider: do not include session ID in SSE event #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kehrlann
force-pushed
the
dgarnier/webmvc-sse-server-transport-session-id
branch
from
27b74a2 to
15d539f
Compare
- This aligns messages with WebFluxSseServerTransportProvider Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
dgarnier/webmvc-sse-server-transport-session-id
branch
from
15d539f to
2c40670
Compare
He-Pin
reviewed
Nov 19, 2025
| this.sessions.put(sessionId, session); | ||
| return ServerResponse.sse(sseBuilder -> { | ||
| WebMvcMcpSessionTransport sessionTransport = new WebMvcMcpSessionTransport(sseBuilder); | ||
| McpServerSession session = sessionFactory.create(sessionTransport); |
chemicL
approved these changes
Nov 20, 2025
Member
chemicL
left a comment
chemicL
left a comment
There was a problem hiding this comment.
This is a useful improvement to the mess that existed there, thank you :)
Contributor
Contributor
Author
|
@He-Pin I'm not sure I understand the ask. MVC is already in a separate module. |
Contributor
|
@Kehrlann oops, wrong memory, what about |
Contributor
Author
|
The idea is to have the basics, SDK+Jakarta base in the core. And you'll notice that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the WebFlux SSE Server transport and WebMVC SSE Server transport do not align in behavior.
The WebMVC transport gets an ID generated an injected, instead of relying on the SessionFactory's generation mechanism.
In this PR, we put the session ID generation back into the factory. This means the "transport session" knows nothing about the session ID, so we remove the id from the SSE events and all the logging data.