Revert "WebClientStreamableHttpTransport: use Spring-5 compatible met…hods (#649)" #696
+12
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods (modelcontextprotocol#649)" This reverts commit 67f8eab.
Contributor
Author
|
@He-Pin unfortunately we can't support SF5 and SF7 and support for later is obviously our priority. |
Contributor
|
Thank you. Can we make these protected methods, then I think I can override them with subtyping |
He-Pin
reviewed
Nov 26, 2025
| return Flux.from(sessionStream.consumeSseStream(idWithMessages)); | ||
| } | ||
|
|
||
| private static boolean isNotFound(ClientResponse response) { |
Contributor
There was a problem hiding this comment.
Please make these methods a protected class method, then I can override them via subtyping.
Contributor
Author
There was a problem hiding this comment.
@He-Pin if framework 5 is important, perhaps you can copy the WebClientStreamableHttpTransport.java and modify and build it locally for your needs.
Kehrlann
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the #649 breaks compatibility with Spring Framework 7.
Spring Framework 7 compatibility takes priority over Spring Framework 5 support.
Remove deprecated rawStatusCode() API usage in WebClientStreamableHttpTransport
that breaks Spring Framework 7 compatibility. Replace with modern statusCode()
API methods including is2xxSuccessful() and isSameCodeAs().