#302 Update samples build workflow #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneTheDev
approved these changes
Oct 22, 2025
| } | ||
| plugins { | ||
| // Apply the foojay-resolver plugin to allow automatic download of JDKs | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0" |
There was a problem hiding this comment.
Same, let's move to libs.versions.toml
samples/weather-stdio-server/src/test/kotlin/io/modelcontextprotocol/sample/client/FakeTest.kt
Show resolved
Hide resolved
devcrocod
reviewed
Oct 22, 2025
| koverLog koverHtmlReport \ | ||
| publishToMavenLocal | ||
| publishToMavenLocal \ | ||
| -Pversion=0.0.1-SNAPSHOT |
There was a problem hiding this comment.
Why is this version being used? Shouldn’t we use the latest version + snapshot instead?
There was a problem hiding this comment.
No, it would be harder to maintain. This is an ephemeral version for the build process only.
There was a problem hiding this comment.
Do we need a separate toml file for each example?
Maybe it would be clearer to specify the versions directly in the build.gradle files instead?
Also, we should check the dependabot workflow to make sure it monitors these files as well
There was a problem hiding this comment.
Yes, samples should be completely independent from SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#302 Update samples build workflow
Motivation and Context
Samples should be independently buildable
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context