-
Notifications
You must be signed in to change notification settings - Fork 178
Add new helper properties to request and notification types #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -16,6 +16,27 @@ public data class CompleteRequest(override val params: CompleteRequestParams) : | |||||||||||
| @OptIn(ExperimentalSerializationApi::class) | ||||||||||||
| @EncodeDefault | ||||||||||||
| public override val method: Method = Method.Defined.CompletionComplete | ||||||||||||
|
|
||||||||||||
| /** | ||||||||||||
| * The argument's information for which completion options are requested. | ||||||||||||
| */ | ||||||||||||
| public val argument: CompleteRequestParams.Argument | ||||||||||||
| get() = params.argument | ||||||||||||
|
|
||||||||||||
| /** | ||||||||||||
| * A reference to either a prompt or resource template to complete within. | ||||||||||||
| */ | ||||||||||||
| public val ref: Reference | ||||||||||||
| get() = params.ref | ||||||||||||
|
|
||||||||||||
| /** | ||||||||||||
| * Additional, context for generating completions. | ||||||||||||
|
||||||||||||
| * Additional, context for generating completions. | |
| * Additional context for generating completions. |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation: The meta property should have a KDoc comment to maintain consistency with other properties in this class. Consider adding: /**\n * Metadata for this request. May include a progressToken for out-of-band progress notifications.\n */
| /** | |
| * Metadata for this request. May include a progressToken for out-of-band progress notifications. | |
| */ |
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -77,7 +77,11 @@ public class Progress( | |||||||||||
| @Serializable | ||||||||||||
| public data class CustomNotification(override val method: Method, override val params: BaseNotificationParams? = null) : | ||||||||||||
| ClientNotification, | ||||||||||||
| ServerNotification | ||||||||||||
| ServerNotification { | ||||||||||||
|
|
||||||||||||
|
||||||||||||
| /** | |
| * Metadata for this notification. | |
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation: The
metaproperty should have a KDoc comment to maintain consistency with similar properties in other request types. Consider adding:/**\n * Metadata for this request. May include a progressToken for out-of-band progress notifications.\n */