[Server] Missing Mcp-Protocol-Version to access control #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
soyuka
commented
Oct 17, 2025
| 'Access-Control-Allow-Methods' => 'GET, POST, DELETE, OPTIONS', | ||
| 'Access-Control-Allow-Headers' => 'Content-Type, Mcp-Session-Id, Last-Event-ID, Authorization, Accept', | ||
| 'Access-Control-Allow-Headers' => 'Content-Type, Mcp-Session-Id, Mcp-Protocol-Version, Last-Event-ID, Authorization, Accept', | ||
| ]; |
There was a problem hiding this comment.
Would it be possible to leave security features to the actual HTTP Proxy server that's running PHP (ie ngin/php/symfony)? Indeed this is hiding security settings and we've no ways of changing it.
There was a problem hiding this comment.
I agree that this is quite opinionated - at least we should have some config to shut it off or overwrite the actual values
chr-hertel
approved these changes
Oct 20, 2025
| 'Access-Control-Allow-Methods' => 'GET, POST, DELETE, OPTIONS', | ||
| 'Access-Control-Allow-Headers' => 'Content-Type, Mcp-Session-Id, Last-Event-ID, Authorization, Accept', | ||
| 'Access-Control-Allow-Headers' => 'Content-Type, Mcp-Session-Id, Mcp-Protocol-Version, Last-Event-ID, Authorization, Accept', | ||
| ]; |
There was a problem hiding this comment.
I agree that this is quite opinionated - at least we should have some config to shut it off or overwrite the actual values
chr-hertel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.