Skip to content

Conversation

@chr-hertel
Copy link
Member

Close #136

@chr-hertel chr-hertel added Server Issues & PRs related to the Server component Schema Issues & PRs related to the Schema component labels Nov 7, 2025
@chr-hertel chr-hertel merged commit 5804ba9 into main Nov 9, 2025
12 checks passed
@chr-hertel chr-hertel deleted the feat-icons-url branch November 9, 2025 13:53
@lvluoyue
Copy link
Contributor

lvluoyue commented Nov 9, 2025

I discovered that the lack of Attribute support will prevent obtaining the tools list.

Typed property Mcp\\Schema\\Tool::$icons must not be accessed before initialization

I have an idea: we can extract the icon into an annotation (meta should also be able to use this method), not sure if it's feasible.

@chr-hertel
Copy link
Member Author

  1. you are right, the attributes should support this as well
  2. how did you run into the error? cannot reproduce with an example 🤔

@lvluoyue
Copy link
Contributor

lvluoyue commented Nov 9, 2025

  1. you are right, the attributes should support this as well
  2. how did you run into the error? cannot reproduce with an example 🤔

I used Discovery Cache, and after clearing the cache, it worked normally. It seems that the cache was not refreshed, which caused the issue.

1 similar comment
@lvluoyue
Copy link
Contributor

lvluoyue commented Nov 9, 2025

  1. you are right, the attributes should support this as well
  2. how did you run into the error? cannot reproduce with an example 🤔

I used Discovery Cache, and after clearing the cache, it worked normally. It seems that the cache was not refreshed, which caused the issue.

@chr-hertel
Copy link
Member Author

That cache hiccup makes sense & and #142 should address your finding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Schema Issues & PRs related to the Schema component Server Issues & PRs related to the Server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Server][SEP-973] Expose additional metadata for Implementations, Resources, Tools and Prompts

4 participants