Fix: Add missing lifespan parameter to StreamableHTTP mounting examples #1494
+112
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes modelcontextprotocol#1484 - Add contextlib import and lifespan function to all mounting examples - Add stateless_http=True parameter to FastMCP constructors - Add lifespan=lifespan parameter to Starlette apps - Update README.md documentation with correct examples - Fixes RuntimeError: Task group is not initialized. Make sure to use run() Resolves the issue where mounting StreamableHTTP servers to existing ASGI applications would fail with RuntimeError due to missing session manager initialization.
Run scripts/update_readme_snippets.py to sync documentation with code changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1484
Fixes the RuntimeError that occurs when mounting StreamableHTTP servers to existing ASGI applications. The error "Task group is not initialized. Make sure to use run()" was caused by missing session manager initialization.
Motivation and Context
RuntimeError: Task group is not initialized. Make sure to use run().when trying to mount StreamableHTTP servers to existing ASGI applications (like Starlette). This was caused by missing session manager initialization. The documentation examples were incomplete and didn't show the requiredlifespanparameter needed to properly initialize the session manager.How Has This Been Tested?
Breaking Changes
No breaking changes. This is a documentation fix that provides the correct implementation pattern.
Types of changes
Checklist
Additional context
N/A