Fix flaky timeout test in test_88_random_error #1525
Merged
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was using a session-level 50ms timeout which caused race conditions in CI environments where operations could occasionally take longer than expected due to system load. The fix uses per-request timeouts instead: - Fast operations use no timeout (None), making them reliable in any environment regardless of system load - The slow operation that should timeout uses a minimal timeout (1 microsecond) to trigger immediately without adding test execution time This eliminates time-based race conditions while keeping the test fast and maintaining its purpose of verifying that the server remains responsive after a timeout occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky test that was causing intermittent CI failures due to race conditions with time-based timeouts.
Problem
The
test_notification_validation_errortest was using a session-level 50ms timeout for all operations. In CI environments with high system load, even "fast" operations could occasionally take longer than 50ms, causing the test to fail unpredictably.The test's purpose is to verify that the server remains responsive after a client request times out, not to test specific timing constraints.
Solution
Replaced the session-level timeout with per-request timeouts:
Fast operations that should succeed: Use
read_timeout_seconds=None(no timeout). This makes them reliable in any environment regardless of system load or resource contention.Slow operation that should timeout: Use
read_timeout_seconds=timedelta(microseconds=1)(1 microsecond). This triggers the timeout immediately without adding execution time to the test.Benefits
Test Plan