fix: Replace fixed sleep with active server readiness check in SSE tests #1526
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_sse_security_wildcard_ports test was flaky due to a race condition where the test tried to connect before uvicorn was ready to accept connections. The original code used time.sleep(1) which was: - Sometimes too short (causing flaky CI failures) - Always wasteful when server started quickly - Non-deterministic This change replaces the arbitrary sleep with wait_for_server() which: - Actively polls the server port until it accepts connections - Returns immediately when ready (faster in most cases) - Has a clear 5-second timeout for true failures - Eliminates the race condition entirely The fix makes the tests deterministic and often faster than before.
felixweinberger
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky test failures in
test_sse_security_wildcard_portsby replacing arbitrary sleep with deterministic server readiness polling.Motivation and Context
The
test_sse_security_wildcard_portstest was intermittently failing in CI with:The root cause was a race condition: the test used
time.sleep(1)to wait for the uvicorn server to start, but this was sometimes insufficient, causing the test to attempt connections before the server was ready.How Has This Been Tested?
Breaking Changes
None. This is purely an internal test improvement.
Types of changes
Checklist
Additional context
The new
wait_for_server()function:TimeoutErroron true failuresThis follows the principle of avoiding arbitrary sleeps in unit tests that can make CI slower and less reliable.