refactor: extract OAuth helper functions and simplify provider state #1586
+427
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxisbey
force-pushed
the
maxisbey/oauth-helpers
branch
2 times, most recently
from
040a546 to
81c470f
Compare
maxisbey
changed the title
| raise OAuthRegistrationError(f"Invalid registration response: {e}") | ||
|
|
||
|
|
||
| async def handle_token_response_scopes( |
There was a problem hiding this comment.
based on the discussion, we’ll want to remove that check from the SDK
maxisbey
force-pushed
the
maxisbey/oauth-helpers
branch
from
6780800 to
fd612f2
Compare
pcarleton
requested changes
Nov 12, 2025
Member
pcarleton
left a comment
pcarleton
left a comment
There was a problem hiding this comment.
looks good, a few minor comments
pcarleton
approved these changes
Nov 13, 2025
Member
pcarleton
left a comment
pcarleton
left a comment
There was a problem hiding this comment.
LGTM!
I did a brief look into other ways to allow using these methods outside of a generator (and also inside) that let us expose a higher level "discover Oauth info" interface.
The only other option seemed to be to have a state machine that has a "next request" method that output a request, but at least the quick sketch of it didn't seem very nice to use.
There might be something to explore on having an async generator specific to auth that is easier to use outside, but this seems like the best option for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors OAuth 2.0 authentication implementation to expose reusable utilities.
Motivation and Context
The OAuth authentication logic was tightly coupled to the httpx auth provider, making it difficult for external tools (like MCP proxies or custom clients) to reuse core OAuth functionality. This refactor extracts the OAuth primitives into standalone utilities that can be used independently.
Key improvements:
How Has This Been Tested?
Existing test suite updated to reflect new structure. All tests pass.
Breaking Changes
None - this is a pure refactor with no API changes.
Types of changes
Checklist
Additional context
New utilities added:
client/auth/utils.py: OAuth protocol helpers (discovery URLs, WWW-Authenticate parsing, scope selection, response handlers)shared/auth_utils.py: PKCE generation and token expiry calculationThe main OAuth2Auth provider (
client/auth/oauth2.py) now delegates to these utilities, reducing from 221 lines to 93 lines of core logic.