Add end-of-file-fixer pre-commit hook #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the end-of-file-fixer hook from pre-commit-hooks to ensure all files in the repository end with a newline character. This improves POSIX compliance and prevents issues with certain tools that expect proper line endings. The hook automatically fixed several files that were missing trailing newlines. Reported-by: Kludex
maxisbey
force-pushed
the
add-end-of-file-fixer
branch
from
919bb6d to
9c58123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
end-of-file-fixerhook from pre-commit-hooks to enforce that all files end with a newline character.Motivation and Context
POSIX standards require text files to end with a newline. Many tools expect this convention, and missing trailing newlines can cause issues with diffs, certain parsers, and shell scripts. This hook automatically ensures all files have proper line endings.
Requested by @Kludex in #1553 (comment)
How Has This Been Tested?
The pre-commit hook was tested by running:
The hook successfully identified and fixed 6 files that were missing trailing newlines:
.gitattribute__init__.pyfilesBreaking Changes
None. This only affects formatting of files to ensure they follow POSIX conventions.
Types of changes
Checklist