Add tests for JSON Schema 2020-12 field preservation (SEP-1613) #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests that verify Tool.inputSchema preserves JSON Schema 2020-12 keywords ($schema, $defs, additionalProperties) through serialization and deserialization. These tests document that the Python SDK already correctly handles SEP-1613 due to using dict[str, Any] for inputSchema. Tests: - test_tool_preserves_json_schema_2020_12_fields: Direct Tool creation - test_list_tools_result_preserves_json_schema_2020_12_fields: Deserialization
maxisbey
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests that verify the Python SDK correctly preserves JSON Schema 2020-12 keywords in tool schemas.
Summary
test_tool_preserves_json_schema_2020_12_fields: VerifiesTool.inputSchemapreserves$schema,$defs, andadditionalPropertiesthrough creation and serializationtest_list_tools_result_preserves_json_schema_2020_12_fields: Verifies fields surviveListToolsResultdeserializationMotivation and Context
SEP-1613 establishes JSON Schema 2020-12 as the default dialect for MCP. These tests document that the Python SDK already correctly handles this due to using
dict[str, Any]forinputSchema(unlike the TypeScript SDK which needed explicit changes in PR #1135).How Has This Been Tested?
pytest tests/test_types.py -vBreaking Changes
None.
Types of changes