Skip to content

Conversation

@maxisbey
Copy link
Contributor

@maxisbey maxisbey commented Dec 9, 2025

Fixes the failing Comment on Released PRs workflow by adding missing GitHub token permissions.

Motivation and Context

The workflow at https://github.com/modelcontextprotocol/python-sdk/actions/runs/20068484009 failed with:

Resource not accessible by integration

This happened because the github-release-commenter action tried to comment on issue #1754 (referenced via "Fixes #1754" in PR #1755), but the workflow only had pull-requests: write permission.

How Has This Been Tested?

This is a workflow permissions fix. The next release will verify the fix works correctly.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Added permissions:

  • issues: write - Required to comment on issues referenced by PRs
  • contents: read - Required to read release/commit information

AI Disclaimer

The github-release-commenter action requires `issues: write` permission
to comment on issues that are referenced by PRs (e.g., "Fixes #1754").
Without this permission, the action fails with "Resource not accessible
by integration".

Also adds `contents: read` to ensure the action can read release/commit
information.
@maxisbey maxisbey added bug Something isn't working P0 Broken core functionality, security issues, critical missing feature labels Dec 9, 2025
@maxisbey maxisbey enabled auto-merge (squash) December 9, 2025 15:35
@maxisbey maxisbey disabled auto-merge December 9, 2025 15:37
@maxisbey maxisbey closed this Dec 9, 2025
@maxisbey maxisbey deleted the fix/release-comment-permissions branch December 9, 2025 15:39
@maxisbey
Copy link
Contributor Author

maxisbey commented Dec 9, 2025

Superseded by #1758 which removes the workflow entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working P0 Broken core functionality, security issues, critical missing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MIME type validation regex doesn't support parameters (e.g., text/html;profile=mcp-app)

2 participants