Skip to content

Add flags for publish subcommand #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add flags for publish subcommand #771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions cmd/publisher/commands/publish.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"context"
"encoding/json"
"errors"
"flag"
"fmt"
"io"
"net/http"
Expand All @@ -17,14 +18,21 @@ import (
)

func PublishCommand(args []string) error {
publishFlags := flag.NewFlagSet("publish", flag.ExitOnError)
serverFile := publishFlags.String("file", "server.json", "Path to server.json (default: ./server.json)")
Copy link
Member

@domdomegg domdomegg Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general philosophy is to avoid configuration options as much as possible - each additional flag is another lever of complexity to maintain, debug, document, etc. And they compose exponentially so you increase the surface area for problems a lot.

I can see this being helpful, although I'd ask first why:

  • the default isn't working, e.g. you can't name it server.json. Note that you could put this in a subfolder and run publish from there
  • failing that, whether it couldn't compose already with other tools (e.g. move the server.json into the right place or a tmp folder, then run publish, then clean up).

registryURLFlag := publishFlags.String("registry", "", "Registry URL override")
dryRun := publishFlags.Bool("dry-run", false, "Validate without publishing")
if err := publishFlags.Parse(args); err != nil {
return fmt.Errorf("failed to parse flags: %w", err)
}

// Check for server.json file
serverFile := "server.json"
if len(args) > 0 && !strings.HasPrefix(args[0], "-") {
serverFile = args[0]
serverFile = &args[0]
}

// Read server.json
serverData, err := os.ReadFile(serverFile)
serverData, err := os.ReadFile(*serverFile)
if err != nil {
if os.IsNotExist(err) {
return fmt.Errorf("server.json not found. Run 'mcp-publisher init' to create one")
Expand Down Expand Up @@ -71,10 +79,17 @@ Migrate to the current schema format for new servers.

token := tokenInfo["token"]
registryURL := tokenInfo["registry"]
Copy link
Member

@domdomegg domdomegg Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the registryUrl probably won't be helpful as your token determines which registry you have authed to

if *registryURLFlag != "" {
registryURL = *registryURLFlag
}
if registryURL == "" {
registryURL = DefaultRegistryURL
}

if *dryRun {
return nil
}

// Publish to registry
_, _ = fmt.Fprintf(os.Stdout, "Publishing to %s...\n", registryURL)
response, err := publishToRegistry(registryURL, serverData, token)
Expand Down
Loading