Skip to content

Conversation

topherbullock
Copy link
Contributor

@topherbullock topherbullock commented Oct 10, 2025

Motivation and Context

Client is missing functionality for resources/list and resources/read

How Has This Been Tested?

Added unit tests to client_test https://github.com/modelcontextprotocol/ruby-sdk/pull/160/files#diff-7daf60c70888017747b710518764087efc6171bb2f5419506cf21a8ac7ef4a5a

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@koic koic merged commit c510600 into main Oct 10, 2025
13 checks passed
@koic koic deleted the client-add-resource-support branch October 10, 2025 16:16
dak2 added a commit to dak2/ruby-sdk that referenced this pull request Oct 11, 2025
Update test_resources_returns_empty_array_when_no_resources to use
correct mock response format with empty resources array instead of
empty result object. Also reorder test to group with other resources
tests.

Follow up: modelcontextprotocol#160
koic added a commit that referenced this pull request Oct 12, 2025
dak2 added a commit to dak2/ruby-sdk that referenced this pull request Oct 13, 2025
- Add test for empty tools array response to ensure client handles empty
  results correctly
- Update call_tool test to use proper content format (array of content
  objects) instead of plain string based on
  modelcontextprotocol spec.
  https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/docs/specification/2025-03-26/server/tools.mdx#calling-tools

Follow up: modelcontextprotocol#160
@topherbullock topherbullock mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants