Skip to content

Conversation

4t145
Copy link
Collaborator

@4t145 4t145 commented Oct 11, 2025

Motivation and Context

fix the problem in #472

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions bot added T-documentation Documentation improvements T-macros Macro changes labels Oct 11, 2025
@4t145 4t145 requested a review from Copilot October 11, 2025 10:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes documentation examples for the tool_router macro by correcting the syntax for the vis (visibility) attribute. The visibility attribute value should be wrapped in quotes as a string literal rather than being an unquoted identifier.

  • Updates documentation examples to use proper string syntax for visibility attribute
  • Adds a test case demonstrating the correct usage with quoted visibility values

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/rmcp-macros/src/tool_router.rs Adds test case with quoted visibility attribute
crates/rmcp-macros/src/lib.rs Fixes documentation examples to use quoted visibility values
crates/rmcp-macros/README.md Updates README examples to use proper quoted syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@4t145 4t145 requested a review from jokemanfire October 11, 2025 10:39
@4t145 4t145 merged commit 75a7e48 into modelcontextprotocol:main Oct 13, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-documentation Documentation improvements T-macros Macro changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants