OAuth discovery to try all candidate URLs before failing. (Closes rust-sdk/issues/544) #545
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-core
jokemanfire
approved these changes
Nov 18, 2025
jokemanfire
merged commit b6cbd39
into
modelcontextprotocol:main
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes OAuth discovery so the RMCP client so it tries all candidate URLs for JSON with valid metadata, rather than failing on the first malformed well-known URL.
Motivation and Context
Closes rust-sdk/issues/544
#544
How Has This Been Tested?
Against live endpoints where it previously failed.
cargo test --package rmcp --features client transport-child-process
Breaking Changes
NO
Types of changes
Checklist
Additional context