fix: don't block on creating the SSE stream #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-core
jamadeo
force-pushed
the
jackamadeo/dont-block-on-stream
branch
from
f78cb36 to
8bbf7c6
Compare
jamadeo
changed the title
alexhancock
approved these changes
Nov 20, 2025
Contributor
alexhancock
left a comment
alexhancock
left a comment
There was a problem hiding this comment.
Nice. It makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some servers don't send any response headers until they have something to stream (specifically the Spring AI mcp sdk). Other clients (typescript, python) don't block on receiving a response to this stream. It's for out-of-band notifications, so it isn't necessary to block here.
How Has This Been Tested?
Tested with block/goose
Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context