-
Notifications
You must be signed in to change notification settings - Fork 1.1k
SEP-1850: Migrate SEP process from issues to pull requests #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+356
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the SEP (Specification Enhancement Proposal) process to use pull requests instead of GitHub issues, inspired by Python's PEP process. Key changes: - SEPs are now submitted as PRs to the seps/ directory (not as issues) - SEP number = PR number (authors amend commit after PR creation) - All discussion happens in the PR, providing a single place for review - Sponsors are responsible for updating status in the markdown file - Full version history maintained via git Benefits: - Proper versioning history for all proposal changes - Single location for discussion (the PR itself) - Clear traceability between proposal and review process - Eliminates need for manual number assignment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Blog Post: #1851 |
Per pcarleton's feedback, sponsors should apply matching labels to PRs in addition to updating the Status field in the markdown file. This makes it easier to filter and search for SEPs by status. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add SEP-1850 documenting the PR-based SEP workflow and a template file for future SEP authors. The SEP formalizes the process of using PR numbers, markdown files in seps/ directory, sponsor responsibilities including status management via PR labels, and the dormant status for unsponsored proposals. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
jonathanhefner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
9 tasks
- Change PR field to full URL for clickable links - Reword sponsor responsibilities to not imply write access requirement - Clarify that authors coordinate status changes with sponsors - Reduce README duplication by referencing TEMPLATE.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Closed
Document the formalized PR-based SEP workflow including markdown files in seps/ directory, PR-derived numbering, sponsor responsibilities, and status management via PR labels. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
This was accepted unanimously by core maintainers 8-0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the SEP (Specification Enhancement Proposal) process to use pull requests instead of GitHub issues, inspired by Python's PEP process.
Key Changes
seps/directory and submitted via pull requests (not GitHub issues)0000-, then amend their commit to use the actual PR numberStatusfield in the SEP markdown fileBenefits
Files Changed
seps/README.md- Complete rewrite as the primary SEP guidedocs/community/sep-guidelines.mdx- Updated workflow to PR-baseddocs/community/governance.mdx- Updated SEP referencesdocs/community/communication.mdx- Clarified where SEPs are submittedMigration Note
This is a process change. Existing SEPs created as issues can continue through their current workflow, but new SEPs should follow the PR-based process.
🤖 Generated with Claude Code