-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featurebugSomething isn't workingSomething isn't workingneeds confirmationNeeds confirmation that the PR is actually required or needed.Needs confirmation that the PR is actually required or needed.
Description
Describe the bug
Hello — thanks to the team for their work on this!
After upgrading @modelcontextprotocol/sdk from 1.22.0 to 1.23.0, I started getting a TS2589: Type instantiation is excessively deep and possibly infinite. error.
It worked in 1.22.0, but 1.23.0 reports this error.
- PR: refactor: fix CI, use
zodv4, and latest method inmcpeslint/rewrite#332 - CI: https://github.com/eslint/rewrite/actions/runs/19728654491/job/56524795666?pr=332
The PR and GitHub Actions CI show the failure:
At first I thought the error was caused by our use of the deprecated tools method, but it also occurs with the new registerTool method.
To Reproduce
Steps to reproduce the behavior:
- Clone the PR: refactor: fix CI, use
zodv4, and latest method inmcpeslint/rewrite#332 - Run
npm installfrom the project root. - Run
npm run build -w packages/mcpfrom the project root.
Expected behavior
No TS2589: Type instantiation is excessively deep and possibly infinite. error should occur.
Logs
Full logs can be found here:
- PR: refactor: fix CI, use
zodv4, and latest method inmcpeslint/rewrite#332 - CI: https://github.com/eslint/rewrite/actions/runs/19728654491/job/56524795666?pr=332
Additional context
This appears to be a regression introduced when adding Zod v4 support in 1.23.0.
robinvw1
Metadata
Metadata
Assignees
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featurebugSomething isn't workingSomething isn't workingneeds confirmationNeeds confirmation that the PR is actually required or needed.Needs confirmation that the PR is actually required or needed.