-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: add closeSSEStream callback to RequestHandlerExtra #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
felixweinberger
wants to merge
2
commits into
main
Choose a base branch
from
fweinberger/closeSSEStream-callback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+242
−11
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import { IncomingMessage, ServerResponse } from 'node:http'; | ||
| import { Transport } from '../shared/transport.js'; | ||
| import { | ||
| CloseSSEStreamOptions, | ||
| MessageExtraInfo, | ||
| RequestInfo, | ||
| isInitializeRequest, | ||
|
|
@@ -649,7 +650,15 @@ export class StreamableHTTPServerTransport implements Transport { | |
|
|
||
| // handle each message | ||
| for (const message of messages) { | ||
| this.onmessage?.(message, { authInfo, requestInfo }); | ||
| // Build closeSSEStream callback for requests when eventStore is configured | ||
| let closeSSEStream: ((options?: CloseSSEStreamOptions) => void) | undefined; | ||
| if (isJSONRPCRequest(message) && this._eventStore) { | ||
| closeSSEStream = (options?: CloseSSEStreamOptions) => { | ||
| this.closeSSEStream(message.id, options?.retryInterval); | ||
| }; | ||
| } | ||
|
|
||
| this.onmessage?.(message, { authInfo, requestInfo, closeSSEStream }); | ||
| } | ||
| // The server SHOULD NOT close the SSE stream before sending all JSON-RPC responses | ||
| // This will be handled by the send() method when responses are ready | ||
|
|
@@ -794,13 +803,22 @@ export class StreamableHTTPServerTransport implements Transport { | |
| * Close an SSE stream for a specific request, triggering client reconnection. | ||
| * Use this to implement polling behavior during long-running operations - | ||
| * client will reconnect after the retry interval specified in the priming event. | ||
| * | ||
| * @param requestId - The request ID whose stream should be closed | ||
| * @param retryInterval - Optional retry interval in milliseconds to send before closing. | ||
| * If provided, sends a retry field to override the transport default. | ||
| */ | ||
| closeSSEStream(requestId: RequestId): void { | ||
| closeSSEStream(requestId: RequestId, retryInterval?: number): void { | ||
| const streamId = this._requestToStreamMapping.get(requestId); | ||
| if (!streamId) return; | ||
|
|
||
| const stream = this._streamMapping.get(streamId); | ||
| if (stream) { | ||
| // If a custom retry interval is provided, send it before closing | ||
| // Use single \n (not \n\n) to avoid triggering SSE event dispatch | ||
| if (retryInterval !== undefined) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't this cause problems for the client? |
||
| stream.write(`retry: ${retryInterval}\n`); | ||
| } | ||
| stream.end(); | ||
| this._streamMapping.delete(streamId); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think you need this any more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too at first, but we do still need this at line 120 below: