Remove type dependency on @cfworker/json-schema #1229
Merged
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
LucaButBoring
force-pushed
the
fix/json-schema-optional-dependencies
branch
from
c7a48b6 to
3a8edf8
Compare
mattzcarey
changed the title
Contributor
|
Updated to use a types packge for JSON schema not ts-ignore. Hope thats okay. Waiting on review from @KKonstantinov or @felixweinberger |
KKonstantinov
approved these changes
Dec 5, 2025
Contributor
Author
|
Should be fine since you added that as a required dep |
Contributor
Author
|
Confirmed working against the repro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
@ts-ignorecomment to avoid a type error in consuming code when@cfworker/json-schemais not installed.Motivation and Context
Currently, the
@cfworker/json-schemapeer dependency is marked as optional; however, if it is not installed, consuming packages will fail to typecheck unless they setskipLibCheck: truein their compiler options. This PR fixes this to ignore errors associated with that import, which will cause it to degrade toanyif the package is not installed.How Has This Been Tested?
Tested
npm run typecheckin this repro before and after installing my local SDK build and making this change.Breaking Changes
None.
Types of changes
Checklist
Additional context