Skip to content

[TorchAcc] fix: fix save config and additional file for swift and peft #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2024
Merged

[TorchAcc] fix: fix save config and additional file for swift and peft #2149

merged 1 commit into from
Sep 28, 2024

Conversation

baoleai
Copy link
Collaborator

@baoleai baoleai commented Sep 28, 2024 •
edited
Loading

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

  1. fix save configuration file and additional file in _save_tpu which is used when using TorchAcc.
  2. delete sharded ckpt of TorchAcc' FSDP after ckpt consolidation.

@baoleai baoleai merged commit 774374f into modelscope:main Sep 28, 2024
1 of 2 checks passed
@baoleai baoleai deleted the features/fix_save_sft_args branch September 28, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jintao-Huang Jintao-Huang Jintao-Huang approved these changes

@Zhikaiiii Zhikaiiii Awaiting requested review from Zhikaiiii

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baoleai @Jintao-Huang