Support the generation of JanusPro models #3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logit_uncond = logits[1::2, :] | ||
|
|
||
| logits = logit_uncond + self.cfg_weight * (logit_cond - logit_uncond) | ||
| probs = torch.softmax(logits / self.temperature, dim=-1) |
There was a problem hiding this comment.
temperature 从generation_config中获取
swift/llm/template/base.py
Outdated
| content = message['content'] | ||
| if not isinstance(content, str): | ||
| continue | ||
| if '<start_image>' in content: |
swift/llm/template/base.py
Outdated
| content = message['content'] | ||
| if not isinstance(content, str): | ||
| continue | ||
| if '<start_image>' in content: |
There was a problem hiding this comment.
中划线；加入special_tokens
swift/llm/template/base.py
Outdated
| if '<start_image>' in content: | ||
| gene_img = True | ||
| message['content'] = re.sub('<start_image>', '', content).strip() # remove the <start_image> | ||
| inputs.gene_img = gene_img |
| cfg_weight: float = 5 | ||
| image_token_num_per_image: int = 576 | ||
| img_size: int = 384 | ||
| patch_size: int = 16 |
There was a problem hiding this comment.
cfg_weight, img_size, patch_size 使用get_env_args函数 从环境变量获取好了
Jintao-Huang
approved these changes
Feb 21, 2025
| content = message['content'] | ||
| if not isinstance(content, str): | ||
| continue | ||
| if content.strip().endswith('<start-image>'): |
There was a problem hiding this comment.
这个的话，用户有可能把<start-image>放末尾以后会再跟几个空格（比如我经常有这个习惯😂）需要考虑吗
| continue | ||
| if content.strip().endswith('<start-image>'): | ||
| generate_mode = True | ||
| message['content'] = re.sub('<start-image>', '', content).strip() # remove the <start-image> |
There was a problem hiding this comment.
message['content'][:-len('<start-image>')]
| from swift.llm import infer_main, InferArguments | ||
| args = InferArguments( | ||
| # model='deepseek-ai/Janus-Pro-1B', | ||
| model='/mnt/nas1/.cache/modelscope/hub/deepseek-ai/Janus-Pro-1B', |
tastelikefeet
added a commit
to tastelikefeet/swift
that referenced
this pull request
Feb 26, 2025
…soth_fast_grpo * commit 'df8939818d2b3694d14120d8fb07eea96e5b99a8': (24 commits) GRPO+LMDeploy 0.7 (modelscope#3277) fix lmdeploy (modelscope#3274) compat lmdeploy 0.7 (modelscope#3256) Fix typos (modelscope#3266) Support the base64 format of generated images for JanusPro (modelscope#3265) grpo_countdown & fix format reward (modelscope#3269) fix grpo compat transformers==4.47.* (modelscope#3252) save val_dataset (modelscope#3248) fix grpo single gpu(modelscope#3246) fix grpo npu vllm (modelscope#3242) update docs (modelscope#3243) support muon optimizer (modelscope#3234) support moonlight (modelscope#3232) fix deepseek_vl2 (modelscope#3233) fix docs zh (modelscope#3231) Speed up GRPO (modelscope#3229) update docs (modelscope#3230) fix load args (modelscope#3226) Update the JanusPro-generation (modelscope#3221) Support the generation of JanusPro models (modelscope#3218) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Support the generation of JanusPro models