Skip to content

fix ddp bug #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix ddp bug #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/pytorch/llm/src/utils/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from torch import dtype as Dtype

from swift import get_logger
from .utils import is_local_master
from .utils import is_dist, is_local_master

logger = get_logger()

Expand Down Expand Up @@ -314,14 +314,14 @@ def get_model_tokenizer(model_type: str,

model_dir = kwargs.pop('model_dir', None)
if model_dir is None:
if not is_local_master():
if is_dist() and not is_local_master():
dist.barrier()
model_dir = model_id
if not os.path.exists(model_id):
revision = data.get('revision', 'master')
model_dir = snapshot_download(
model_id, revision, ignore_file_pattern=ignore_file_pattern)
if is_local_master():
if is_dist() and is_local_master():
dist.barrier()

model, tokenizer = get_function(model_dir, torch_dtype, load_model,
Expand Down