[bugfix] fix template extra_kwargs

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug related to how extra_kwargs were handled within template inputs. The change simplifies the initialization logic for 'chosen' and 'rejected' template components, ensuring that all relevant keyword arguments are correctly passed and utilized, thereby resolving an issue where some parameters might have been inadvertently dropped due to an incorrect filtering mechanism.

Highlights

• Simplified extra_kwargs handling: The logic for processing 'chosen' and 'rejected' template inputs has been streamlined by directly passing the full dictionary to StdTemplateInputs.from_dict, removing an unnecessary manual key filtering step.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue where extra keyword arguments (extra_kwargs) were being dropped for chosen and rejected attributes in TemplateInputs. The change simplifies the code by directly passing the value_dict to StdTemplateInputs.from_dict, which is the correct approach. However, the same bug persists for the positive and negative attributes, which are handled in the else block of the same method. The current implementation for these attributes still filters keys, causing any extra keyword arguments to be lost. I've left a comment with a suggestion to address this for a complete fix.

[gemini-code-assist]

This change correctly fixes the issue for chosen and rejected attributes. However, the same issue of dropping extra_kwargs exists for positive and negative attributes in the else block that follows. The logic there still iterates over all_keys, which filters out any extra arguments not defined in StdTemplateInputs.

To ensure consistency and fully resolve the bug, please consider refactoring the else block to preserve all keyword arguments, similar to the fix made here. For example:

            else:
                res = []
                if not value_dict or 'messages' not in value_dict:
                    continue
                
                num_items = len(value_dict['messages'])
                for i in range(num_items):
                    item_kwargs = {k: v[i] for k, v in value_dict.items()}
                    res.append(StdTemplateInputs.from_dict(item_kwargs))
                setattr(self, key, res)