-
Notifications
You must be signed in to change notification settings - Fork 906
update requirements #5826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update requirements #5826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on maintaining the project's technical documentation and installation procedures by updating recommended dependency versions and refining installation scripts. The changes ensure that users are directed to the most current and compatible versions of essential libraries, improving the overall development and deployment experience. Additionally, a minor adjustment was made to the test suite to reflect current testing priorities.
Highlights
- Dependency Version Updates: Recommended versions for several key libraries including
python
,transformers
,deepspeed
,vllm
,sglang
, andlmdeploy
have been updated across various documentation files (READMEs and installation guides). - Installation Script Refinements: The
install_all.sh
script now includes updated version constraints forvllm
andtransformers
, and addswandb
andswanlab
to the list of installed packages. - Test Configuration Adjustment: The
test_vision.py
file has been modified to enable thetest_keye_vl_1_5()
function while commenting outtest_minicpmv4_5()
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependency versions across various documentation files and the main installation script. While most changes are straightforward version bumps, I've identified a critical issue in requirements/install_all.sh
that would cause the script to fail due to a typo. Additionally, several markdown tables in the documentation have become misaligned, impacting readability. My review includes suggestions to fix the installation script and correct the table formatting.
requirements/install_all.sh
Outdated
pip install "deepspeed" -U | ||
pip install qwen_vl_utils qwen_omni_utils decord librosa icecream soundfile -U | ||
pip install liger_kernel nvitop pre-commit math_verify py-spy -U | ||
pip install liger_kernel nvitop pre-commit math_verify py-spy wandb swanlab-U |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in this command. The -U
flag for pip install
has been incorrectly appended to swanlab
, which will cause the installation to fail. It should be a separate argument at the end of the command.
pip install liger_kernel nvitop pre-commit math_verify py-spy wandb swanlab-U | |
pip install liger_kernel nvitop pre-commit math_verify py-spy wandb swanlab -U |
| python | >=3.9 | 3.10/3.11 | | | ||
| cuda | | cuda12 | No need to install if using CPU, NPU, MPS | | ||
| torch | >=2.0 | 2.7.1 | | | ||
| transformers | >=4.33 | 4.55.4 | | | ||
| transformers | >=4.33 | 4.56.1 | | | ||
| modelscope | >=1.23 | | | | ||
| peft | >=0.11,<0.18 | | | | ||
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | ||
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | ||
| deepspeed | >=0.14 | 0.16.9 | Training | | ||
| vllm | >=0.5.1 | 0.10 | Inference/Deployment | | ||
| sglang | >=0.4.6 | 0.4.9.post6 | Inference/Deployment | | ||
| lmdeploy | >=0.5 | 0.9.2 | Inference/Deployment | | ||
| deepspeed | >=0.14 | 0.17.5 | Training | | ||
| vllm | >=0.5.1 | 0.10.1.1 | Inference/Deployment | | ||
| sglang | >=0.4.6 | 0.4.10.post2 | Inference/Deployment | | ||
| lmdeploy | >=0.5 | 0.9.2.post1 | Inference/Deployment | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this table has become misaligned after the recent updates, which affects readability. Please consider re-aligning the columns for better presentation.
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | No need to install if using CPU, NPU, MPS | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.55.4 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.16.9 | Training | | |
| vllm | >=0.5.1 | 0.10 | Inference/Deployment | | |
| sglang | >=0.4.6 | 0.4.9.post6 | Inference/Deployment | | |
| lmdeploy | >=0.5 | 0.9.2 | Inference/Deployment | | |
| deepspeed | >=0.14 | 0.17.5 | Training | | |
| vllm | >=0.5.1 | 0.10.1.1 | Inference/Deployment | | |
| sglang | >=0.4.6 | 0.4.10.post2 | Inference/Deployment | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | Inference/Deployment | | |
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | No need to install if using CPU, NPU, MPS | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.17.5 | Training | | |
| vllm | >=0.5.1 | 0.10.1.1 | Inference/Deployment | | |
| sglang | >=0.4.6 | 0.4.10.post2 | Inference/Deployment | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | Inference/Deployment | |
| python | >=3.9 | 3.10/3.11 | | | ||
| cuda | | cuda12 | 使用cpu、npu、mps则无需安装 | | ||
| torch | >=2.0 | 2.7.1 | | | ||
| transformers | >=4.33 | 4.55.4 | | | ||
| transformers | >=4.33 | 4.56.1 | | | ||
| modelscope | >=1.23 | | | | ||
| peft | >=0.11,<0.18 | | | | ||
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | ||
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | ||
| deepspeed | >=0.14 | 0.16.9 | 训练 | | ||
| vllm | >=0.5.1 | 0.10 | 推理/部署 | | ||
| sglang | >=0.4.6 | 0.4.9.post6 | 推理/部署 | | ||
| lmdeploy | >=0.5 | 0.9.2 | 推理/部署 | | ||
| deepspeed | >=0.14 | 0.17.5 | 训练 | | ||
| vllm | >=0.5.1 | 0.10.1.1 | 推理/部署 | | ||
| sglang | >=0.4.6 | 0.4.10.post2 | 推理/部署 | | ||
| lmdeploy | >=0.5 | 0.9.2.post1 | 推理/部署 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this table has become misaligned after the recent updates, which affects readability. Please consider re-aligning the columns for better presentation.
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | 使用cpu、npu、mps则无需安装 | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.55.4 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.16.9 | 训练 | | |
| vllm | >=0.5.1 | 0.10 | 推理/部署 | | |
| sglang | >=0.4.6 | 0.4.9.post6 | 推理/部署 | | |
| lmdeploy | >=0.5 | 0.9.2 | 推理/部署 | | |
| deepspeed | >=0.14 | 0.17.5 | 训练 | | |
| vllm | >=0.5.1 | 0.10.1.1 | 推理/部署 | | |
| sglang | >=0.4.6 | 0.4.10.post2 | 推理/部署 | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | 推理/部署 | | |
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | 使用cpu、npu、mps则无需安装 | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.17.5 | 训练 | | |
| vllm | >=0.5.1 | 0.10.1.1 | 推理/部署 | | |
| sglang | >=0.4.6 | 0.4.10.post2 | 推理/部署 | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | 推理/部署 | |
docs/source/GetStarted/SWIFT安装.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this table has become misaligned after the recent updates, which affects readability. Please consider re-aligning the columns for better presentation.
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | 使用cpu、npu、mps则无需安装 | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.55.4 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.16.9 | 训练 | | |
| vllm | >=0.5.1 | 0.10 | 推理/部署 | | |
| sglang | >=0.4.6 | 0.4.9.post6 | 推理/部署 | | |
| lmdeploy | >=0.5 | 0.9.2 | 推理/部署 | | |
| deepspeed | >=0.14 | 0.17.5 | 训练 | | |
| vllm | >=0.5.1 | 0.10.1.1 | 推理/部署 | | |
| sglang | >=0.4.6 | 0.4.10.post2 | 推理/部署 | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | 推理/部署 | | |
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | 使用cpu、npu、mps则无需安装 | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.17.5 | 训练 | | |
| vllm | >=0.5.1 | 0.10.1.1 | 推理/部署 | | |
| sglang | >=0.4.6 | 0.4.10.post2 | 推理/部署 | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | 推理/部署 | |
docs/source/Megatron-SWIFT/快速开始.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this table has become misaligned after the recent updates, which affects readability. Additionally, the apex
row seems to have an incorrect number of columns. Please consider re-aligning the columns and fixing the table structure for better presentation.
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | | | |
| torch | >=2.0 | 2.6.0/2.7.1 | | | |
| transformer_engine | >=2.3 | | | | |
| apex | | 0.1 | | | |
| megatron_core | >=0.12 | 0.13 | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| transformers | >=4.33 | 4.51.3 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | | | |
| torch | >=2.0 | 2.6.0/2.7.1 | | | |
| transformer_engine | >=2.3 | | | | |
| apex | | 0.1 | | | |
| megatron_core | >=0.12 | 0.13 | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| transformers | >=4.33 | 4.56.1 | | |
| python | >=3.9 | 3.10/3.11 | | | ||
| cuda | | cuda12 | No need to install if using CPU, NPU, MPS | | ||
| torch | >=2.0 | 2.7.1 | | | ||
| transformers | >=4.33 | 4.55.4 | | | ||
| transformers | >=4.33 | 4.56.1 | | | ||
| modelscope | >=1.23 | | | | ||
| peft | >=0.11,<0.18 | | | | ||
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | ||
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | ||
| deepspeed | >=0.14 | 0.16.9 | Training | | ||
| vllm | >=0.5.1 | 0.10 | Inference/Deployment | | ||
| sglang | >=0.4.6 | 0.4.9.post6 | Inference/Deployment | | ||
| lmdeploy | >=0.5 | 0.9.2 | Inference/Deployment | | ||
| deepspeed | >=0.14 | 0.17.5 | Training | | ||
| vllm | >=0.5.1 | 0.10.1.1 | Inference/Deployment | | ||
| sglang | >=0.4.6 | 0.4.10.post2 | Inference/Deployment | | ||
| lmdeploy | >=0.5 | 0.9.2.post1 | Inference/Deployment | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this table has become misaligned after the recent updates, which affects readability. Please consider re-aligning the columns for better presentation.
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | No need to install if using CPU, NPU, MPS | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.55.4 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.16.9 | Training | | |
| vllm | >=0.5.1 | 0.10 | Inference/Deployment | | |
| sglang | >=0.4.6 | 0.4.9.post6 | Inference/Deployment | | |
| lmdeploy | >=0.5 | 0.9.2 | Inference/Deployment | | |
| deepspeed | >=0.14 | 0.17.5 | Training | | |
| vllm | >=0.5.1 | 0.10.1.1 | Inference/Deployment | | |
| sglang | >=0.4.6 | 0.4.10.post2 | Inference/Deployment | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | Inference/Deployment | | |
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | No need to install if using CPU, NPU, MPS | | |
| torch | >=2.0 | 2.7.1 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| modelscope | >=1.23 | | | | |
| peft | >=0.11,<0.18 | | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| trl | >=0.15,<0.21 | 0.20.0 | RLHF | | |
| deepspeed | >=0.14 | 0.17.5 | Training | | |
| vllm | >=0.5.1 | 0.10.1.1 | Inference/Deployment | | |
| sglang | >=0.4.6 | 0.4.10.post2 | Inference/Deployment | | |
| lmdeploy | >=0.5 | 0.9.2.post1 | Inference/Deployment | |
| python | >=3.9 | 3.10/3.11 | | | ||
| cuda | | cuda12 | | | ||
| torch | >=2.0 | 2.6.0/2.7.1 | | | ||
| transformer_engine | >=2.3 | | | | ||
| apex | | 0.1 | | | ||
| megatron_core | >=0.12 | 0.13 | | | ||
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | ||
| transformers | >=4.33 | 4.51.3 | | | ||
| transformers | >=4.33 | 4.56.1 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this table has become misaligned after the recent updates, which affects readability. Additionally, the apex
row seems to have an incorrect number of columns. Please consider re-aligning the columns and fixing the table structure for better presentation.
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | | | |
| torch | >=2.0 | 2.6.0/2.7.1 | | | |
| transformer_engine | >=2.3 | | | | |
| apex | | 0.1 | | | |
| megatron_core | >=0.12 | 0.13 | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| transformers | >=4.33 | 4.51.3 | | | |
| transformers | >=4.33 | 4.56.1 | | | |
| python | >=3.9 | 3.10/3.11 | | | |
| cuda | | cuda12 | | | |
| torch | >=2.0 | 2.6.0/2.7.1 | | | |
| transformer_engine | >=2.3 | | | | |
| apex | | 0.1 | | | |
| megatron_core | >=0.12 | 0.13 | | | |
| flash_attn | | 2.7.4.post1/3.0.0b1 | | | |
| transformers | >=4.33 | 4.56.1 | | |
No description provided.