-
Notifications
You must be signed in to change notification settings - Fork 906
[fix] swift eval parameter dataset_args is replaced by eval_dataset_args #5969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @liulei08, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug related to inconsistent parameter naming within the evaluation module. It renames the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 旨在修复 swift eval
中的参数命名不一致问题,将 dataset_args
重命名为 eval_dataset_args
,使其与训练过程中的参数保持一致。代码变更简单明了,逻辑正确。我唯一的建议是为这个新参数补充相应的测试用例,以保证其功能的稳定性和正确性。
eval_dataset: List[str] = field(default_factory=list) | ||
eval_limit: Optional[int] = None | ||
dataset_args: Optional[Union[Dict, str]] = None | ||
eval_dataset_args: Optional[Union[Dict, str]] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方便把文档也修改一下不 然后加一下 dataset_args 的向后兼容,默认为None,如果设置了,就覆盖eval_dataset_args |
好的,文档我也改一下 |
PR type
PR information
修复swift eval参数dataset_args为eval_dataset_args,与训练过程中eval的对应参数保持一致。
对应的issue:#5968
Experiment results
Paste your experiment result here(if needed).