-
Notifications
You must be signed in to change notification settings - Fork 906
[model] support Qwen/Qwen3-VL-30B-A3B-Instruct/Thinking #6037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[model] support Qwen/Qwen3-VL-30B-A3B-Instruct/Thinking #6037
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's model capabilities by integrating several new Qwen3-VL models, including their instruction-tuned, 'thinking,' and FP8 optimized variants. This ensures that users have access to the latest Qwen models and their efficient versions for various tasks. The changes also include necessary updates to the documentation to reflect these additions and a minor cleanup in the trainer module's import structure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for new Qwen3-VL models, including 30B and 235B variants with FP8 quantization. The changes are well-organized, with consistent updates to the model registration in swift/llm/model/model/qwen.py
and the corresponding documentation in both Chinese and English. The code also includes a minor but beneficial cleanup by removing the deprecated EvaluationStrategy
import from the trainers module. Overall, the changes are correct and improve the project. Good work!
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for new Qwen3-VL models and updates compatibility with newer versions of the transformers
library. The changes are generally well-implemented, including necessary patches for model compatibility and forward-compatible adjustments for the trainer. I've identified one medium-severity issue where the code for model registration doesn't match the documentation regarding Megatron support, which could lead to confusion or unexpected behavior for users.
Hi @Jintao-Huang - could you please share with me the number of H100s for full parameter fine-tune of Qwen3-VL-30B-A3B? Should 2 nodes of 8xH100 suffice? or maybe 8xB200? I will use Megatron |
No description provided.