Skip to content

compat sglang 0.5.3 #6057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

compat sglang 0.5.3 #6057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
314e15f
compat sglang 053
Jintao-Huang Oct 9, 2025
0e28ee2
fix
Jintao-Huang Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/framework.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ tiktoken
tqdm
transformers>=4.33,<4.58
transformers_stream_generator
trl>=0.15,<0.21
trl>=0.15,<0.24
uvicorn
zstandard
3 changes: 2 additions & 1 deletion swift/llm/infer/infer_engine/sglang_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,14 @@ def __init__(
parameters = inspect.signature(ServerArgs).parameters
if 'pp_size' in parameters:
engine_kwargs['pp_size'] = pp_size
if 'enable_ep_moe' in parameters:
engine_kwargs['enable_ep_moe'] = enable_ep_moe
Comment on lines 74 to +77
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve code maintainability and reduce repetition, this block can be refactored to handle conditional keyword arguments more generically by iterating over a list of parameter names and their corresponding values.

Suggested change
if 'pp_size' in parameters:
engine_kwargs['pp_size'] = pp_size
if 'enable_ep_moe' in parameters:
engine_kwargs['enable_ep_moe'] = enable_ep_moe
for param, value in [('pp_size', pp_size), ('enable_ep_moe', enable_ep_moe)]:
if param in parameters:
engine_kwargs[param] = value

self.server_args = ServerArgs(
model_path=self.model_dir,
dtype=self.model_info.torch_dtype,
tp_size=tp_size,
dp_size=dp_size,
ep_size=ep_size,
enable_ep_moe=enable_ep_moe,
mem_fraction_static=mem_fraction_static,
context_length=context_length,
disable_cuda_graph=disable_cuda_graph,
Expand Down
2 changes: 2 additions & 0 deletions swift/llm/train/tuner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,8 @@ def prepare_adapter(args: TrainArguments, model, *, template=None, train_dataset
)
logger.info(f'bone config: {bone_config}')
model = Swift.prepare_model(model, bone_config)
else:
raise ValueError(f'Unknown train_type: {args.train_type}')
return model


Expand Down
Loading