Skip to content

Fix command line display for UI #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
+2 −2
Merged

Fix command line display for UI #6603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb278d
Fix a bug in the command line display on the UI.
slin000111 Nov 14, 2025
1bd1e92
Merge branch 'fix_ui_extra_env_param' into main
slin000111 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions swift/ui/llm_train/llm_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,8 +467,8 @@ def train(cls, *args):
else:
cuda_param = ''
if envs:
envs = envs.split(' ')
for env in envs:
env_list = envs.split(' ')
for env in env_list:
k, v = env.split('=')
all_envs[k] = v
Comment on lines +470 to 473
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly avoids shadowing the envs variable, the environment variable parsing logic can be made more robust. The current implementation has two potential issues:

  1. If there are multiple spaces between environment variable definitions (e.g., A=1 B=2), split(' ') will produce empty strings, causing a ValueError when unpacking.
  2. If an environment variable's value contains an = sign (e.g., URL=http://a.com?x=y), split('=') will produce more than two values, also causing a ValueError.

I suggest a more robust implementation that also simplifies the code by removing the intermediate env_list.

Suggested change
env_list = envs.split(' ')
for env in env_list:
k, v = env.split('=')
all_envs[k] = v
for env in envs.split(' '):
if env and '=' in env:
k, v = env.split('=', 1)
all_envs[k] = v

log_file = os.path.join(sft_args.logging_dir, 'run.log')
Expand Down
Loading