Skip to content

[template] support add_eos #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2025
Merged

[template] support add_eos #6613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc69953
support add_eos
Jintao-Huang Nov 16, 2025
25157fb
update
Jintao-Huang Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion swift/llm/template/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,11 @@ def _swift_encode(self, inputs: StdTemplateInputs):
if isinstance(stop_word, str))
# self.is_training needed because we may want to continue generation from
# the current response
if (self.is_training or self.task_type != 'causal_lm') and not sep_token and not endswith_stop_words:
add_eos = inputs.extra_kwargs.get('add_eos')
if add_eos is None:
add_eos = (self.is_training
or self.task_type != 'causal_lm') and not sep_token and not endswith_stop_words
if add_eos:
extra_context_list = template_meta.suffix
extra_context_type = ContextType.SUFFIX
Comment on lines +1143 to 1148
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and limit variable scope, it's better to declare and use the add_eos logic entirely within this block, as it's the only place it's used. Using a local variable like add_eos_flag makes it clear that its scope is confined here.

With this change, you can remove the declaration add_eos = inputs.extra_kwargs.get('add_eos') from line 1102.

Suggested change
if add_eos is None:
add_eos = (self.is_training
or self.task_type != 'causal_lm') and not sep_token and not endswith_stop_words
if add_eos:
extra_context_list = template_meta.suffix
extra_context_type = ContextType.SUFFIX
add_eos_flag = inputs.extra_kwargs.get('add_eos')
if add_eos_flag is None:
add_eos_flag = (self.is_training
or self.task_type != 'causal_lm') and not sep_token and not endswith_stop_words
if add_eos_flag:
extra_context_list = template_meta.suffix
extra_context_type = ContextType.SUFFIX

elif template_meta.response_prefix:
Expand Down
Loading