Skip to content

[bugfix]fix add_eos in gkd/grpo for truncated sample encode #6618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

[bugfix]fix add_eos in gkd/grpo for truncated sample encode #6618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swift/trainers/rlhf_trainer/rollout_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ def merge_output_input_data(input_data: Dict[str, Union[torch.Tensor, Any]], out

input_data['finish_reason'] = choice.finish_reason
input_data['is_truncated'] = choice.finish_reason == 'length'

input_data['add_eos'] = not choice.finish_reason == 'length'
if output.rollout_infos:
multi_modal_keys = ['images', 'videos', 'audios']
for key in multi_modal_keys:
Expand Down
Loading