Update postprocessing.py #1329
Update postprocessing.py #1329
Conversation
The upper correction is not necessary, but with the second little correction of adding .flatten() to line 63, the function was returning an indexing error.
Codecov Report
@@ Coverage Diff @@
## develop #1329 +/- ##
==============================================
- Coverage 74.730% 29.532% -45.198%
==============================================
Files 247 247
Lines 53384 52010 -1374
==============================================
- Hits 39894 15360 -24534
- Misses 13490 36650 +23160
|
| frf = np.zeros(shape, dtype=float).flatten() | ||
| fff = np.zeros(shape, dtype=float).flatten() | ||
| flf = np.zeros(shape, dtype=float) | ||
| flf = np.zeros(shape, dtype=float).flatten() |
There was a problem hiding this comment.
Can you add a test to show that this is necessary?
There was a problem hiding this comment.
Please run the two small testing programs, called 1)test_w_modfified_version.py and 2)test_w_nonmodfified_version.py, to see the difference in the output, thanks.
|
@askar-INTERA, thanks for submitting this PR. I went ahead and implemented this fix on a separate PR (#1333) and I also added a test. You'll see in #1333 the type of test we are looking for to ensure the fix is correct. We like to add small fast tests that demonstrate working functionality with the code fix. Thanks! |
|
Thanks for doing that and sorry that I am not familiar with the type of tests you need as I am still new to GitHub. Excuse my limited knowledge about GitHub but I assume the new separate PR #1333 is totally created by you and will not give me any credit for this little fix, correct? |
|
Yes, PR #1333 is a new and separate pull request so it will not be attributed to you. However, your PR is documented here and so there is a trail to you. If you can adopt our test requirements and add them to your future PRs, then the fixes will be made in your name. |
2 participants
The upper correction is not necessary, but with the second little correction of adding .flatten() to line 63, the function was returning an indexing error.