Skip to content

fix(mfdataplist): fix dangling file handle #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

fix(mfdataplist): fix dangling file handle #2615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions flopy/mf6/data/mfdataplist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,10 +1775,14 @@ def _write_file_entry(
return ""

# Write out pre-data comments (including headers) like MFList does
mode = "w"
if fd_data_file is not None and data_storage.pre_data_comments:
if not hasattr(fd_data_file, "write"):
fd_data_file = open(fd_data_file, "w")
fd_data_file.write(data_storage.pre_data_comments.get_file_entry())
if hasattr(fd_data_file, "write"):
fd_data_file.write(data_storage.pre_data_comments.get_file_entry())
else:
mode = "a"
with open(fd_data_file, "w") as f:
f.write(data_storage.pre_data_comments.get_file_entry())

# Loop through data pieces
data = self._remove_cellid_fields(data_storage.internal_data)
Expand Down Expand Up @@ -1828,6 +1832,7 @@ def _write_file_entry(
sep=" ",
header=False,
index=False,
mode=mode,
float_format=float_format,
lineterminator="\n",
)
Expand Down
Loading